-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Windows package building with Azure #1560
Conversation
6440c4d
to
2a1ed7f
Compare
@loriab could you add a pipeline variable, please. |
I've added the var on Azure (several hours ago now, sorry). Also sent invite for write access to psi4meta. There's no PRs there -- just free pushing to master. I'm expecting the |
a23eced
to
2dcd11f
Compare
Now Azure can build an optimized Psi4, run all the tests, and make a conda package: https://dev.azure.com/raimisg/psi4/_build/results?buildId=569 Queue time variables:
The built package is on Anaconda: https://anaconda.org/raimis/psi4/files You can install and try:
|
@loriab I see you have already created, |
Wonderful news! And got it -- will figure out the two way merge. Now to find someone with a Windows box to try this out ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hooray, lgtm
- networkx | ||
- numpy | ||
- pytest | ||
- python={{ PY_VER }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, I think we'll want to break out separate packages for deps and to use run_exports
and pin_compatible
for version constraints, but great for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! Currently, libxc
and libinit
are statically linked. So the dependency shouldn't be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agree -- can't cause trouble as-is.
OK! So this PR goes to |
Sounds good. Slight complication is that when I wrote the versioner.py script that computes our version (and integrates w/cmake), I had the misguided notion that all commits on a release branch were version increments (that is, your PR would turn into v1.3.1 or .2), so I'll have to unwind that scheme before any proper tag of a v1.3.1 w/your PR. Just FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for figuring this out. LGTM
* Add conda recipe for Windows * Enable package building * Package Psi4 scripts * Add an option to trigger package building * Clean up conda/win/meta.yaml
Description
This is part of Psi4 porting to Windows (#933).
Enable conda package building for Windows with Azure.
Todos
Notable points (developer or user-interest) that this PR has or will accomplish.
conda.build
with defaultfalse
(settable at queuing time)Questions
conda/win
. Maybe it should be somewhere in https://github.com/psi4/psi4meta/? --> Recipe will stay inconda/win
, for now.Checklist
Tests added for any new featuresStatus