remove obviously unnecessary parentheses #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsol
approved these changes
May 14, 2019
There was a problem hiding this comment.
I was wondering if we could do parens normalization as a post-processing step once we already have decided on the lines, or during splitting (like we currently do), or pre-split (like this PR is doing). I doing it in one place makes Black more easy to understand.
Until then, this looks good enough :) 👍
|
@JelleZijlstra does this also remove parens in except blocks that don't need it? # in
try:
raise ValueError("hi")
except (ValueError):
pass
# out
try:
raise ValueError("hi")
except ValueError:
passThanks! |
This was referenced Oct 13, 2019
Closed
Merged
JelleZijlstra
added a commit
to JelleZijlstra/black
that referenced
this pull request
Oct 20, 2019
Merged
JelleZijlstra
added a commit
that referenced
this pull request
Oct 20, 2019
Fixes #1042 (and probably #1044 which looks like the same thing). The issue with the "obviously unnecessary" parentheses that #850 removed is that sometimes they're necessary to help Black fit something in one line. I didn't see an obvious solution that still removes the parens #850 was intended to remove, so let's back out this change for now in the interest of unblocking a release. This PR also adds a test adapted from the failing example in #1042, so that if we try to reapply the #850 change we don't break the same case again.
amyreese
pushed a commit
to amyreese/black
that referenced
this pull request
May 7, 2020
Fixes psf#1042 (and probably psf#1044 which looks like the same thing). The issue with the "obviously unnecessary" parentheses that psf#850 removed is that sometimes they're necessary to help Black fit something in one line. I didn't see an obvious solution that still removes the parens psf#850 was intended to remove, so let's back out this change for now in the interest of unblocking a release. This PR also adds a test adapted from the failing example in psf#1042, so that if we try to reapply the psf#850 change we don't break the same case again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548
This removes all parentheses around very simple nodes (e.g.,
(1),(x)). Perhaps we can do something more aggressive, like removing them around function call or attribute access expressions.