Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Travis #614

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Refactor Travis #614

merged 3 commits into from
Nov 20, 2018

Conversation

JelleZijlstra
Copy link
Collaborator

  • Run separate jobs for mypy, self-formatting, flake8, and test runs.
  • Don't run flake8 in 3.8 because it is broken (and we can't really expect flake8 to always keep up with 3.8 development).

- Run separate jobs for mypy, self-formatting, flake8, and test runs.
- Don't run flake8 in 3.8 because it is broken (and we can't really expect flake8 to always keep up with 3.8 development).
@JelleZijlstra
Copy link
Collaborator Author

(WIP because I just wrote this code in the web editor and I have no idea whether it will work.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 804

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.094%

Totals Coverage Status
Change from base Build 801: 0.03%
Covered Lines: 2903
Relevant Lines: 3021

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 808

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.094%

Totals Coverage Status
Change from base Build 801: 0.03%
Covered Lines: 2903
Relevant Lines: 3021

💛 - Coveralls

@@ -2,24 +2,38 @@ sudo: required
dist: xenial
language: python
cache: pip
env:
- TEST_CMD="coverage run tests/test_black.py"
install:
- pip install coverage coveralls flake8 flake8-bugbear mypy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could speed up builds slightly by only installing what we need, but Travis is pretty fast already and most of this is probably cached anyway, so I don't think it's really worth doing.

@JelleZijlstra JelleZijlstra changed the title [WIP] Refactor Travis Refactor Travis Nov 20, 2018
@JelleZijlstra JelleZijlstra merged commit 8d58827 into master Nov 20, 2018
@JelleZijlstra JelleZijlstra deleted the no3.8 branch November 20, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants