Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Travis CI and migrate Coveralls #2186

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented May 3, 2021

Travis CI for Open Source is shutting down in a few weeks so the queue
for jobs is insane due to lower resources. I'm 99.99% sure we don't need
it as our Test, Lint, Docs, Upload / Package, Primer, and Fuzz workflows
are all on GitHub Actions. So even though we can migrate to the .com
version with its 1000 free Linux minutes(?), I don't think we need to.

more information here:

This commit does the following:

  • delete the Travis CI configuration
  • add to the GHA test workflows so coverage continues to be recorded
    • tweaked coverage configuration so this wouldn't break
  • remove any references to Travis CI in the docs (i.e. readme + sphinx
    docs)

Regarding the Travis CI to GitHub Actions Coveralls transition, the
official action doesn't support the coverage files produced by coverage.py
unfornately. Also no, I don't really know what I am doing so don't @ me
if this breaks :p (well you can, but don't expect me to be THAT useful).

The Coveralls setup has two downfalls AFAIK:

  • Only Linux runs are used because AndreMiras/coveralls-python-action
    only supports Linux. Although this isn't a big issue since the Travis
    Coveralls configuration only used Linux data too.
  • Pull requests from an internal branch (i.e. one on psf/black) will be
    marked as a push coverage build by Coveralls since our anti-duplicate-
    workflows system runs under the push even for such cases.

Resolves GH-1971.

@ichard26 ichard26 added C: cleanup Refactoring and removing dust :) skip news Pull requests that don't need a changelog entry. labels May 3, 2021
@ichard26 ichard26 marked this pull request as draft May 3, 2021 22:02
@cooperlees cooperlees self-requested a review May 3, 2021 22:08
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ...

@ichard26
Copy link
Collaborator Author

ichard26 commented May 3, 2021

It's still very disfunctional.

@ichard26 ichard26 force-pushed the drop-travis branch 10 times, most recently from 6973304 to 542d64d Compare May 3, 2021 23:52
Travis CI for Open Source is shutting down in a few weeks so the queue
for jobs is insane due to lower resources. I'm 99.99% sure we don't need
it as our Test, Lint, Docs, Upload / Package, Primer, and Fuzz workflows
are all on GitHub Actions. So even though we *can* migrate to the .com
version with its 1000 free Linux minutes(?), I don't think we need to.

more information here:
- https://blog.travis-ci.com/oss-announcement
- https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
- https://docs.travis-ci.com/user/migrate/open-source-repository-migration

This commit does the following:
- delete the Travis CI configuration
- add to the GHA test workflows so coverage continues to be recorded
  - tweaked coverage configuration so this wouldn't break
- remove any references to Travis CI in the docs (i.e. readme + sphinx
  docs)

Regarding the Travis CI to GitHub Actions Coveralls transition, the
official action doesn't support the coverage files produced by coverage.py
unfornately. Also no, I don't really know what I am doing so don't @ me
if this breaks :p (well you can, but don't expect me to be THAT useful).

The Coveralls setup has two downfalls AFAIK:
- Only Linux runs are used because AndreMiras/coveralls-python-action
  only supports Linux. Although this isn't a big issue since the Travis
  Coveralls configuration only used Linux data too.
- Pull requests from an internal branch (i.e. one on psf/black) will be
  marked as a push coverage build by Coveralls since our anti-duplicate-
  workflows system runs under the push even for such cases.
@ichard26 ichard26 marked this pull request as ready for review May 4, 2021 00:20
@ichard26
Copy link
Collaborator Author

ichard26 commented May 4, 2021

Oh dear that took a long time to sort out, the silver lining is that 1) this works! 🎉 and 2) I learned a lot about GitHub Actions.

Don't mind the cancelled primer runs, I didn't want to waste resources so I cancelled / disabled a LOT of runs.

@ambv ambv merged commit 5918a01 into psf:master May 4, 2021
@ichard26 ichard26 deleted the drop-travis branch May 4, 2021 13:17
@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: cleanup Refactoring and removing dust :) C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate off Travis CI (.org)
3 participants