New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 🍰 ✨ isn't appropriate when it fails #300

Closed

peterbe opened this issue Jun 5, 2018 · 0 comments

Contributor

peterbe commented Jun 5, 2018

It's not a bug, more of an enhancement/feature request.
I run black --check dir/with/files and get this output:

...
would reformat /app/tests/test_ingest_backfill.py
would reformat /app/tests/test_main_models.py
would reformat /app/tests/test_ingest_sqs.py
All done! ✨ 🍰 ✨
23 files would be reformatted, 11 files would be left unchanged.

It's "all done" as in it's finished checking all the files. But the ✨ 🍰 ✨ emojis are way to happy when in fact the whole check failed.

The text was updated successfully, but these errors were encountered:

peterbe added a commit to peterbe/black that referenced this issue


✨ 🍰 ✨ isn't appropriate when it fails, fixes psf#300

ca3910b

ambv closed this as completed in

aeaaf57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment