New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJob is in batch/v1beta1 not batch/v1 #33

Merged

psFried merged 1 commit into psFried:master from edwardgeorge:master

Aug 24, 2020

Contributor

edwardgeorge commented Aug 23, 2020

Modifies k8s_types.rs to have CronJob under version v1beta1 instead of v1.

Fixes #32

CronJob in k8s_types.rs is defined as under the v1 batch api, but it does not exist in this version. It exists under v1beta1 and is not in v1.

This has the effect that if you specify .with_child(k8s_types::batch::v1::CronJob, ...) on your operator config then you get no events at all being processed, the operator appears to hang and do nothing. (which may perhaps be a separate bug?)

This operator config now processes events as expected:

    let operator_config = OperatorConfig::new(OPERATOR_NAME, PARENT_TYPE)
        .with_child(k8s_types::batch::v1beta1::CronJob, ChildConfig::replace());


CronJob is in batch/v1beta1 not batch/v1

ea3d673

Owner

psFried commented Aug 24, 2020

Thanks a lot for fixing this!

psFried merged commit 80bfc2b into psFried:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment