Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SWIFT_VERSION to XCode project #43

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

mathieumg
Copy link
Contributor

Without this, the pod install fails on CocoaPods 1.6.0 with the following error:

$ pod install
Analyzing dependencies
Pre-downloading: `iOSPhotoEditor` from `https://github.com/prscX/photo-editor`
Downloading dependencies
Installing iOSPhotoEditor (0.5)
[!] Unable to determine Swift version for the following pods:

- `iOSPhotoEditor` does not specify a Swift version and none of the targets (`RNPhotoEditor`) integrating it have the `SWIFT_VERSION` attribute set. Please contact the author or set the `SWIFT_VERSION` attribute in at least one of the targets that integrate this pod.

Even though it do is specified therein. This works around that.

@prscX prscX self-assigned this Feb 19, 2019
@prscX
Copy link
Owner

prscX commented Feb 19, 2019

Thanks @mathieumg for sharing the PR.

I have merged the same.

Thanks
</ Pranav >

@prscX prscX merged commit 9a3c48e into prscX:master Feb 19, 2019
@mathieumg mathieumg deleted the swift-version-in-project branch February 19, 2019 16:48
@mathieumg
Copy link
Contributor Author

Thanks @prscX for the responsiveness! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants