Now using standard request code for PHOTO_EDITOR_REQUEST
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current request code simply seems to be the timestamp when it was done, but it needs to be a 16 bit int. See prscX#21 and https://developer.android.com/training/basics/intents/result It doesn't have to be unique across apps, it's just to validate that the results comes from that request. It could be any other 16 bit number if desired. Fixes prscX#21
|
Thanks @mathieumg for the PR and Effort. I have merged the same. Thanks |
|
@prscX would you mind cutting a release (0.0.6) with this fix :) ? Much appreciated! |
|
Sure @dozoisch. Today I am planning to take a cut for 0.0.6. Will keep you posted. Thanks |
|
@prscX thank you 🙌 |
|
Hi @dozoisch: I have pushed the release with fix. Can you please install and verify the same. Please let me know in case you face any issues. Thanks |
|
@prscX thank you very much! Will do immediately :) Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current request code simply seems to be the timestamp of when it was done, but it needs to be a 16 bit integer. See #21 and https://developer.android.com/training/basics/intents/result
It doesn't have to be unique across apps, it's just to validate that the results comes from that request. It could be any other 16 bit number if desired.
Fixes #21