Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use array instead of jQuery "add" method to improve performance #39

Merged
merged 1 commit into from
Jan 23, 2015

Conversation

robertfausk
Copy link

...when creating list with all inview elements cause there is no need to have a sorted element list.
This improves performance drastically when very many elements have to be checked, e.g. more than 200.
Also removed trailing whitespaces.

From http:https://api.jquery.com/add/

When all elements are members of the same document, the resulting collection from .add() will be sorted in document order;
that is, in order of each element's appearance in the document.

…creating list with all inview elements

remove trailing whitespaces
tiff added a commit that referenced this pull request Jan 23, 2015
use array instead of jQuery "add" method to improve performance
@tiff tiff merged commit c313273 into protonet:master Jan 23, 2015
@tiff
Copy link
Member

tiff commented Jan 23, 2015

Thank you!

@robertfausk
Copy link
Author

Thank you too for very ultra fast merging.
Could you also release a new tag? I think v1.0.1 would be the next step cause there are no changes in api.

@robertfausk robertfausk deleted the performance-improvements branch January 23, 2015 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants