Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using #ifdef to work both on Qt4 and Qt5 #37

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Conversation

hosseinn
Copy link

This one should work both on Qt4 and Qt5. Please review.

@alium
Copy link

alium commented Aug 22, 2015

Errors:

  1. single_inst/qtsingleapplication.h:43:30: fatal error: QtGui/QApplication: No such file or directory
  2. configdialog.h:4:25: fatal error: QtGui/QDialog: No such file or directory
  3. mainwindow.h:4:29: fatal error: QtGui/QMainWindow: No such file or directory

I can compile qt4 version, but qt5 version give me this errors above - see: https://stackoverflow.com/questions/8995399/error-qapplication-no-such-file-or-directory and/or https://stackoverflow.com/questions/14260475/qdialog-not-such-file-or-directory-qt-windows

@hosseinn
Copy link
Author

Which Qt version do you use? Run this to have a clean make environment:
(You should make sure that you have Qt5 variables set correctly.)

qmake znotes.pro
make distclean
qmake znotes.pro
make

@alium
Copy link

alium commented Aug 22, 2015

@ hosseinn:
I'm very sorry, my mistake, I was wrong edited PKGBUILD, and until now I noticed. Works fine!

proton added a commit that referenced this pull request Aug 25, 2015
Using #ifdef to work both on Qt4 and Qt5
@proton proton merged commit 6423c5e into proton:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants