Add micro Registered Extension Number #9767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unistack-org/micro (microservices framework) uses protoc-gen-go-micro generator that has extension support for additional framework related options. It is currently not using any registered extension number, so i want to stabilise this and i think that this is a good thing. See here for an example of the extenstion in action.
acozzette
requested changes
Apr 8, 2022
|
1143 will be used by gnostic =)) |
|
Oh sorry, I missed that pulled request. This looks good to me then. I will fix the merge conflict and merge this. |
acozzette
approved these changes
Apr 8, 2022
|
@acozzette thanks ! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unistack-org/micro (microservices framework) uses protoc-gen-go-micro generator that has extension support for additional framework related options.
It is currently not using any registered extension number, so i want to stabilise this and i think that this is a good thing.