[Ruby] Fix RepeatedField#last, #first inconsistencies #9722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepeatedField#last(n)
has an off-by-one error resulting in one more element being returned than requested.While I was at it, I also fixed the following inconsistencies with
Array
:last(n)
where n > size should return all elements; the current implementation wraps around such that e.g.last(size + 2) == last(2)
last(n)
where n < 0 should raise anArgumentError