Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting change to target frameworks that breaks kokoro #9692

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

mkruskal-google
Copy link
Member

Kokoro tests were broken by 10df21e

@dlj-NaN
Copy link
Contributor

dlj-NaN commented Mar 28, 2022

Unfortunately, we don't run aarch64 in presubmit, so I guess we'll see what happens...

@jskeet FYI. I'm not sure if this is the right change, but we did end up seeing errors in the continuous build.

@mkruskal-google
Copy link
Member Author

Yea I noticed that. I took a closer look at the failure though and I'm now fairly confident this is the issue. crosses fingers

@mkruskal-google mkruskal-google merged commit 43bb1bf into protocolbuffers:master Mar 29, 2022
@jskeet
Copy link
Contributor

jskeet commented Mar 29, 2022

It's somewhat strange if net6.0 works but net60 doesn't... but there's no harm in terms of the testing itself. (Basically they should mean the same thing.)

@mkruskal-google
Copy link
Member Author

@jskeet It was the other way around. "net6.0" produced errors like this in our continuous testing:

/usr/share/dotnet/sdk/6.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(267,5): error NETSDK1005: Assets file '/work/csharp/src/Google.Protobuf.Test/obj/project.assets.json' doesn't have a target for 'net60'. Ensure that restore has run and that you have included 'net60' in the TargetFrameworks for your project. [/work/csharp/src/Google.Protobuf.Test/Google.Protobuf.Test.csproj]

@jskeet
Copy link
Contributor

jskeet commented Mar 29, 2022

Sorry, yes - that's what I meant. Basically I'd expect it to work for both or neither...

@mkruskal-google
Copy link
Member Author

IIUC the issue was only for csharp_aarch64 which runs the tests with dotnet publish ... -f net60 .../Google.Protobuf.Test.csproj. Other architectures use netcoreapp3.1, so they didn't hit this issue. As we mentioned above though, we weren't able to confirm this in github so I'm not 100% sure that was the issue

@jskeet
Copy link
Contributor

jskeet commented Mar 29, 2022

Ah, right - so changing the script to use -f net6.0 is probably the more appropriate fix, in the long run. (I think net6.0 is a more "canonical" form of the target framework.)

@mkruskal-google
Copy link
Member Author

Fair enough, I wasn't sure where that was specified so this was the quicker fix. Either way sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants