Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] remove redundant public modifiers for compiled code #9642

Merged

Conversation

mscheong01
Copy link
Contributor

fixes: #9641 : removes all public visibility modifiers from kotlin protobuf code generation

@deannagarcia
Copy link
Member

If you fix the conflicts I can try to run the tests again.

@mscheong01
Copy link
Contributor Author

@deannagarcia done 😄

@deannagarcia
Copy link
Member

If you have a chance to look at the failures that would be great, otherwise I can take a look when I have a chance (but will probably be a week before I get to it).

@mscheong01
Copy link
Contributor Author

I made a fix where a val was accidentally removed along with a public. It should hopefully fix the failures

Copy link
Member

@deannagarcia deannagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@deannagarcia deannagarcia merged commit 5f920d1 into protocolbuffers:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kotlin] protoc compiled code includes redundant public modifiers
5 participants