Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an extension number for protoc-gen-jsonschema #8999

Conversation

chrusty
Copy link
Contributor

@chrusty chrusty commented Sep 19, 2021

Some users of my project have requested features which will require custom field options. I've picked some high random ones for now, but it would be good to do this the proper way! I hope you have plenty of address space here.

@google-cla
Copy link

google-cla bot commented Sep 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 19, 2021
@acozzette
Copy link
Member

@chrusty I think the CLA bot is giving us an error because your email address is not set on the commit. Would you mind amending the commit to set the same email address you used to sign the CLA?

@chrusty chrusty force-pushed the options_extension_protoc_gen_jsonschema branch from 61e083d to 15b98a6 Compare September 20, 2021 22:05
@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 20, 2021
@chrusty
Copy link
Contributor Author

chrusty commented Sep 20, 2021

@acozzette hey, I updated and the cla-bot has given my PR a green label. Now it looks like I need some other labels to be added before this can be approved / merged, but I guess that is up to you.

Thanks for looking at this!

@chrusty
Copy link
Contributor Author

chrusty commented Sep 20, 2021

Awesome, thanks!

@chrusty chrusty deleted the options_extension_protoc_gen_jsonschema branch September 20, 2021 22:23
JasonLunn pushed a commit to JasonLunn/protobuf that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants