Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete HAVE_PTHREADS check (we use std::mutex now). #8257

Closed
wants to merge 2 commits into from

Conversation

haberman
Copy link
Member

@haberman haberman commented Feb 3, 2021

No description provided.

acozzette added a commit to acozzette/protobuf that referenced this pull request Oct 14, 2021
This is based on @haberman's changes in protocolbuffers#8257. Now that we're using
std::mutex we no longer need to check whether pthreads are available, so
this commit removes references to HAVE_PTHREAD. I left the autotools
build alone, though, since we are likely to drop support for it soon
anyway.
acozzette added a commit that referenced this pull request Oct 15, 2021
This is based on @haberman's changes in #8257. Now that we're using
std::mutex we no longer need to check whether pthreads are available, so
this commit removes references to HAVE_PTHREAD. I left the autotools
build alone, though, since we are likely to drop support for it soon
anyway.
@acozzette
Copy link
Member

Let me mark this closed because I submitted a version of this in #9100.

@acozzette acozzette closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants