-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to represent "further out" arrivals at a stop? #10
Comments
I like this idea, and it solves a lot of questions I was having with implementation. To address each point:
|
faultyserver
added a commit
that referenced
this issue
Jul 20, 2016
The middleware is capable of interpreting events, managing associations between relevant objects, and publishing new events such as `vehicle_update` on routes. This implements most of #10, but the embeding of associated objects is yet to be done.
This should be closed by bfd566f. |
faultyserver
added a commit
that referenced
this issue
Jul 27, 2016
Culmination of the previous 3 commits. Route events in Conductor are now a little more DRY as well as succinct, thanks to the safe navigation operator (&.) of Ruby 2.3. Embedding uses the safe navigation to only embed existing station objects, and only occurs on `update` and `activate` events, since there is no real need for them in the `deactivate` event. Also, Ruby 2.3 is nice&.safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unless I'm mistaken, right now a station will only show that it has a vehicle approaching if that vehicle is no more than 3 stops away. This is probably fine for frequent, short loops (e.g. Silver Loop), but I think it poses some problems on larger, more infrequent routes.
Scenario: I'm trying to take the 1B from Cary to Greyhouse (true story). I select the "Stadium & Russell" stop. Currently, there is a 1B arriving in 8 minutes that is 5 stops away, and another arriving in 38 minutes that is 25 stops away. Neither would be shown and I would be left to assume that 1B doesn't come here.
So, here's a proposal:
activate
anddeactivate
events, and updating internal representation of stations as routes are activated on them.vehicle_update
event on the route's topic and updating anassociated_vehicles
property or similar.last_event
on station's id to get the data needed to show the view.meta.last_event
on each vehicle on routes that serve the station to get a vehicle's data before its next heartbeat.approach
anddepart
are superfluous, but we still care aboutdeactivate
.If this were implemented, I think vehicle-on-station events could be removed.
The text was updated successfully, but these errors were encountered: