Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require rugged 0.23.1 #84

Merged
merged 2 commits into from Sep 5, 2015
Merged

Require rugged 0.23.1 #84

merged 2 commits into from Sep 5, 2015

Conversation

dankohn
Copy link
Contributor

@dankohn dankohn commented Jul 21, 2015

As a fix for libgit2/rugged#475

It also requires this line for rugged in the Gemfile:

  gem 'rugged', github: 'libgit2/rugged', ref: '233da19', submodules: true

@mvz
Copy link
Contributor

mvz commented Jul 27, 2015

Looks like the build failed because rugged 0.23.0 wasn't out yet five days ago.

@HaiTo
Copy link

HaiTo commented Jul 27, 2015

i want it ;)

@codebender
Copy link

Which is now available.
@dankohn dankohn changed the title Require rugged 0.23.0 Require rugged 0.23.1 Aug 12, 2015
@stim371
Copy link

stim371 commented Aug 14, 2015

I'm curious why you lock down the dependencies so tightly. ~> 0.22.0 stopped everyone from grabbing 0.23.0 when it came out.

If all of your gemspec dependencies only specify down to the minor version, (~> 0.22) it will allow users to upgrade all the way up to (but not including) the next major version of the gem, which should stop any breaking changes but allow installers to more fluidly specify and upgrade dependencies.

@mvz
Copy link
Contributor

mvz commented Aug 14, 2015

I'm curious why you lock down the dependencies so tightly.

I can understand this, since the major version is 0. There's no real guarantee there that 0.23 will be compatible with 0.22.

@felixmohnert
Copy link

I really want this, since otherwise it is not working on a Mac with a fresh install of Yosemite and the newest Ruby.

mmozuras added a commit that referenced this pull request Sep 5, 2015
@mmozuras mmozuras merged commit 66c57b0 into prontolabs:master Sep 5, 2015
@mmozuras
Copy link
Member

mmozuras commented Sep 5, 2015

rugged version bump was released as part of 0.4.3.

Back from vacation, reviewing issues and continuing work on 0.5.0 😄

@codebender
Copy link

@mmozuras Thanks! 😸

@felixmohnert
Copy link

@mmozuras Yep, thanks a lot. I was now able to give pronto a try and it works perfectly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants