Fix potential issue with commenting on "out of date" lines #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like this solution is quite right...back to the drawing board :-P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #39
We were seeing this issue come up a lot when running pronto on our pull requests. It turns out that when you're looking through the commits for the offending line, you find the first commit where the line exists, regardless of whether or not it's added, deleted, or it's just a context line. As a result you could potentially commit an offending line (that violates rubocop in our case), and then commit a change to a nearby line. When scanning the patches, it would pick the most recent patch, even though that line was actually committed earlier.
What do you think of this? Does it make sense to only find lines that are additions?