Allow the default commit to run against to be configured #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mknapik you've looked at some other config-related PRs, any time to give this one a quick glance? 🙏 |
ashkulz
approved these changes
Sep 6, 2021
|
Thanks for the contribution, @ozydingo! Sorry for the delay in reviewing 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case
For repositories whose mainline branch is not
master(new Github projects now default tomain, and some projects require pull requests againstdevelopmentor similar), allow the default target branch for pronto to be configured. If not configured, it remainsmaster.Notes
Similar to other congiruations, it can be specified in
.pronto.yml(usingdefault_commit) or by environment variable (PRONTO_DEFAULT_COMMIT).The
-cflag is still supported to specify a target commit. Nevertheless, configuring a default makes sense when the existing defaultmasterdoes not even exist in a project as is the case for many new Github repos.Issue: #412