Detect Pull Request id automatically if not specified #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @comment_cache["#{repo}/#{pull_id}/#{sha}"] ||= begin | ||
| client.pull_comments(repo, pull_id).map do |comment| | ||
| pull_id = pull_id(repo) | ||
| @comment_cache["#{repo.github_slug}/#{pull_id}/#{sha}"] ||= begin |
There was a problem hiding this comment.
Note to self: repo is used everywhere in this class. Consider refactoring and just making it a constructor param.
|
Great! ❤️ ❤️ ❤️ |
|
@willnet thanks, would not have happened without you! 😄 |
mmozuras
added a commit
that referenced
this pull request
Oct 15, 2014
Detect Pull Request id automatically if not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@willnet I'm kinda stealing a bit of your idea/code here, so want to make sure you're 🆗 with it. Of course, you're given credit in CHANGELOG 😄