Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax rugged gem dependency #379

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

renatolond
Copy link
Contributor

@renatolond renatolond commented May 13, 2020

Rugged just released v1.0 to match libgit. It is expected to be API compatible with 0.28, which is already supported by pronto. (from https://github.com/libgit2/libgit2/releases)

This relaxes the rugged dependency to accept 1.0.x releases.

Fixes #377 .

@renatolond renatolond requested a review from a team as a code owner May 13, 2020 07:08
Copy link
Contributor

@mknapik mknapik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the build is failing with Rugged error. It seems master is broken as well so it's not related to this PR.
However, until it's fixed I don't think we can merge any PR.

@renatolond
Copy link
Contributor Author

I'll check when I have some time, maybe it's already a change in one of the 0.20 series that was not caught up before.

@renatolond
Copy link
Contributor Author

There, I've tested locally with 0.28 and 0.99 and it seems that #380 fixes the tests that are broken here

@mknapik mknapik merged commit 09a9e85 into prontolabs:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax rugged dependency
2 participants