Bitbucket deprecated its API v1.0: update all endpoints to API v2.0 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(pull_requests wasn't updated)
…chow-master # Conflicts: # lib/pronto/clients/bitbucket_client.rb
|
thanks @bradrees, let's wait @doomspork review and merge it :D |
|
Actually, I'm getting duplicate comments on the commit/pr, I'll try investigate the cause. It appears to be that the existing comments are not being read or matched to the new ones. |
At the moment it just gives an obtuse NoMethodError when the response does not contains a 'values' key
|
I've included paging to get all the comments, which addresses the duplicates issue. I've been using this for a few weeks and it appears all good now! |
|
All merged, it is good to go! |
|
@doomspork could you take a look, @bradrees fixed all conflicts. |
Currently if you create a top level 'file' comment on the PR, it breaks as the comment has no line property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging of 3 pull requests #347, #348 and #352, plus my changes to update the endpoints.
The only significant change here is to use the
commitendpoint instead of the removedchangesetendpoint. This appears to be working for me, and I'm getting the comments on my commit as per before the v2.0 change.@doomspork, @starchow please take a look, thanks!
https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Busername%7D/%7Brepo_slug%7D/commit/%7Bnode%7D/comments#post