Bump rainbow 3.0 #287
Merged
Bump rainbow 3.0 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that this breaks the MRI 2.0 tests |
|
@dylanpinn can you try |
|
@mvz That looks to have fixed the Travis build. |
|
Guys, what happened here, we need a new version released. |
|
Indeed. When this is going to be merged? |
|
@mmozuras It looks pretty straightforward. I'm merging it. |
aergonaut
added a commit
to aergonaut/pronto
that referenced
this pull request
Aug 17, 2018
Add link to [pronto-goodcheck](https://github.com/aergonaut/pronto-goodcheck). Note: This depends on the [unreleased change to allow rainbow 3.0](prontolabs#287), so this shouldn't be merged until that change is released to avoid confusing people. I think the version conflict can be ignored if using Bundler and pronto is specified as a Git dependency instead of from RubyGems. But I think we would rather have people using RubyGems, and this also doesn't work for someone who isn't using Bundler.
Merged
doomspork
pushed a commit
that referenced
this pull request
Aug 20, 2018
Add link to [pronto-goodcheck](https://github.com/aergonaut/pronto-goodcheck). Note: This depends on the [unreleased change to allow rainbow 3.0](#287), so this shouldn't be merged until that change is released to avoid confusing people. I think the version conflict can be ignored if using Bundler and pronto is specified as a Git dependency instead of from RubyGems. But I think we would rather have people using RubyGems, and this also doesn't work for someone who isn't using Bundler.
apiology
pushed a commit
to apiology/pronto
that referenced
this pull request
Dec 27, 2019
Bump rainbow 3.0
apiology
pushed a commit
to apiology/pronto
that referenced
this pull request
Dec 27, 2019
Add link to [pronto-goodcheck](https://github.com/aergonaut/pronto-goodcheck). Note: This depends on the [unreleased change to allow rainbow 3.0](prontolabs#287), so this shouldn't be merged until that change is released to avoid confusing people. I think the version conflict can be ignored if using Bundler and pronto is specified as a Git dependency instead of from RubyGems. But I think we would rather have people using RubyGems, and this also doesn't work for someone who isn't using Bundler.
AdamHawkinsa
pushed a commit
to AdamHawkinsa/pronto
that referenced
this pull request
Nov 20, 2023
Add link to [pronto-goodcheck](https://github.com/aergonaut/pronto-goodcheck). Note: This depends on the [unreleased change to allow rainbow 3.0](prontolabs/pronto#287), so this shouldn't be merged until that change is released to avoid confusing people. I think the version conflict can be ignored if using Bundler and pronto is specified as a Git dependency instead of from RubyGems. But I think we would rather have people using RubyGems, and this also doesn't work for someone who isn't using Bundler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282