Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To integrate pronto into a CI environment (e.g.: Jenkins), it is more convenient to have a checkstyle formatter #24

Merged
merged 1 commit into from
May 28, 2014

Conversation

gabealmer
Copy link
Contributor

No description provided.

end
@checkstyle = REXML::Element.new('checkstyle', @document)
end
private :open_xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the private keyword above all private methods to be make it more consistent.

@mmozuras
Copy link
Member

👍 Looks really good, just fix that minor quibble 😄

Would love to know more how you're using/intend to use pronto with CI!

@gabealmer
Copy link
Contributor Author

The plan is to set up a Jenkins job for our Rails project to run pronto nightly, first with rubocop and maybe rails best practices.
I wanted to use a similar solutions like in https://github.com/eitoball/rubocop-checkstyle_formatter and https://github.com/maroekun/rails_best_practices-formatter/
It seemed easier to implement it in pronto, than configure and use these formatters individually.
With this checkstyle formatter I would be able to use the Violations plugin

We have a dashboard in the office, so from Jenkins it would be super cool to extract that info and display it somehow.

That's the plan, and maybe the first step is now done 😄

If I finish it, I will let you know how is it working 😄

mmozuras added a commit that referenced this pull request May 28, 2014
To integrate pronto into a CI environment (e.g.: Jenkins), it is more convenient to have a checkstyle formatter
@mmozuras mmozuras merged commit ab14857 into prontolabs:master May 28, 2014
@mmozuras
Copy link
Member

@gabealmer sounds great, looking forward to hear how that goes 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants