Support ENV for all config options #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
commented
Oct 5, 2016
| @@ -12,6 +12,7 @@ def initialize(config_hash = ConfigFile.new.to_h) | |||
| end | |||
|
|
|||
| def consolidate_comments? | |||
| @config_hash['consolidate_comments'] ||= ENV['CONSOLIDATE_COMMENTS'] | |||
There was a problem hiding this comment.
Should ENV variables take precedence?
There was a problem hiding this comment.
@doomspork yes - they do everywhere else 😄
|
How about prefixing each |
|
@mknapik sounds like a good idea 👍. Could you (or @doomspork) make a separate pull request for it? |
|
@mmozuras I can update this PR. Do you want me to prefix all the configuration options (a breaking change)? |
|
@doomspork nah, just update according to my one comment. And then let's make a separate PR with all options prefixed. |
|
@mmozuras sounds good! 👍 |
|
@doomspork thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy @mmozuras! Following up on the conversation here, this PR enables support for ENV variables on all configuration options.