-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Octokit 8.0 #453
Comments
ashkulz
pushed a commit
that referenced
this issue
Nov 9, 2023
fixes #453 -- needed to migrate from using "position" to "line" where applicable
alalexander
added a commit
to freshworks/pronto
that referenced
this issue
Nov 15, 2023
fixes prontolabs#453 -- needed to migrate from using "position" to "line" where applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Octokit v8.0.0 was released with changes to the way pull request comments are created. They have removed the deprecated position argument and replaced it with
line
https://github.com/octokit/octokit.rb/releases/tag/v8.0.0
octokit/octokit.rb#1566
https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request
The text was updated successfully, but these errors were encountered: