Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pronto::Git::Patch#new_file_path public for plugin authors to use #366

Closed
apiology opened this issue Dec 27, 2019 · 1 comment · Fixed by #369
Closed

Make Pronto::Git::Patch#new_file_path public for plugin authors to use #366

apiology opened this issue Dec 27, 2019 · 1 comment · Fixed by #369

Comments

@apiology
Copy link
Contributor

It looks like the GitHub reporter (at least) won't report on an issue if we provide the absolute path in the Message object. This is, for instance, what pronto-rubocop does: https://github.com/prontolabs/pronto-rubocop/blob/master/lib/pronto/rubocop/offense_line.rb#L19

Unfortunately, the convenience method to pull this is private:
https://github.com/prontolabs/pronto/blob/master/lib/pronto/git/patch.rb#L42

It'd be nice if this were public.

@doomspork
Copy link
Member

@apiology I see no problem with this, would you please submit a PR with appropriate test coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants