-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Pronto::Git::Patch#new_file_path public for plugin authors to use #366
Comments
@apiology I see no problem with this, would you please submit a PR with appropriate test coverage? |
apiology
added a commit
to apiology/pronto
that referenced
this issue
Jan 5, 2020
doomspork
pushed a commit
that referenced
this issue
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the GitHub reporter (at least) won't report on an issue if we provide the absolute path in the Message object. This is, for instance, what pronto-rubocop does: https://github.com/prontolabs/pronto-rubocop/blob/master/lib/pronto/rubocop/offense_line.rb#L19
Unfortunately, the convenience method to pull this is private:
https://github.com/prontolabs/pronto/blob/master/lib/pronto/git/patch.rb#L42
It'd be nice if this were public.
The text was updated successfully, but these errors were encountered: