Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to golang/dep + depedencies updates #79

Closed
wants to merge 2 commits into from

Conversation

sdurrheimer
Copy link
Contributor

@sdurrheimer sdurrheimer commented Aug 28, 2017

  • Switch kardianos/govendor to golang/dep
  • Update dependencies
  • Use viper.SetDefault since nested keys has been fixed with Nested maps spf13/viper#195

Fixes #40

@grobie
Copy link
Member

grobie commented Aug 28, 2017

I'm generally fine with switching from govendor to dep, but this should be discussed first. I believe we should strive for similar tooling in all of our golang projects in the prometheus org.

Also given Gopkg.lock, we could decide to stop actually vendoring projects.

@sdurrheimer
Copy link
Contributor Author

sdurrheimer commented Aug 28, 2017

I'm generally fine with switching from govendor to dep, but this should be discussed first.

Sure, that one of the reason I've opened a PR = )

@grobie
Copy link
Member

grobie commented Aug 28, 2017 via email

@SuperQ
Copy link
Member

SuperQ commented Sep 25, 2018

Apparently dep is now deprecated.

@sdurrheimer
Copy link
Contributor Author

Is it ? I thought they would continue to maintain it alongside Golang 1.11 modules.

@SuperQ
Copy link
Member

SuperQ commented Sep 27, 2018

It will still be there, but I'd rather not jump from govendor to dep, just to have to switch again.

@SuperQ
Copy link
Member

SuperQ commented Nov 29, 2018

Closing in favor of #117.

@SuperQ SuperQ closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update viper vendor
3 participants