Add HTTP multiplexor wrapper for automatic telemetry. #6
Conversation
ghost
assigned | } | ||
|
|
||
| funcDelegator struct { | ||
| delegate func(http.ResponseWriter, *http.Request) |
There was a problem hiding this comment.
delegate http.HandlerFunc
|
You said you're not 100% happy with the API, but can you expand on that a bit? If DefaultCoarseMux should be a dropin replacement for DefaultServeMux, I guess I don't see how the "API" presented here could be any different... |
|
@peterbourgon, yeah, what I am not so happy about is how to conveniently and with the least overhead provide a simple means for someone to wrap their existing exports and get standardized telemetry for that. In looking into using the Mux case further, I am uncertain that this is the route I want to continue in. I'll issue a follow-up revision to outline a few ideas. |
|
@peterbourgon and @juliusv, please go ahead and give this version a look. I am unsure as to whether the drop-in-replacement model is really the thing to do, but I am willing to expand the interface around this and publicize:
This would enable folks to get standardized Prometheus telemetry for multiple HTTP server multiplexors. Let me ask you this, what would you and the lazy like to use? |
| ) | ||
|
|
||
| func init() { | ||
| flag.StringVar(&listeningAddress, "listeningAddress", ":8080", "The address to listen to requests on.") |
There was a problem hiding this comment.
var (
listen = flag.String("listen", ":8080", "address to listen to requests")
)Maybe: more compact, less stuttering, no less clarity, and more idiomatic to boot (I think).
There was a problem hiding this comment.
Good call. I'll refresh this throughout.
|
Discussion about 'exp' notwithstanding, ⛵ |
|
Cool. Those package refactorings will occur in a follow-up. |
|
Really nice and looks good to me 👍 |
Add HTTP multiplexor wrapper for automatic telemetry.
No description provided.