Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testutil metric comparison #497

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Fix testutil metric comparison #497

merged 2 commits into from
Nov 13, 2018

Commits on Nov 13, 2018

  1. Expose bug #494 

    Signed-off-by: beorn7 <[email protected]>
    beorn7 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1db4379 View commit details
    Browse the repository at this point in the history

  2. Fix metric comparison for empty labels 

    reflect.DeepEqual is not suitable for zero occurrences of repeated
proto messages. This changes the comparison to act on the string
representation of proto messages.

Signed-off-by: beorn7 <[email protected]>
    beorn7 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    86702ea View commit details
    Browse the repository at this point in the history