Support Protocol Buffer Message Decoding #21
Conversation
This commit introduces an incomplete processor that decodes varint record length-delimited streams of io.prometheus.client.MetricFamily Protocol Buffer messages. The Go client presently does not support generation of said messages, but this will unblock a number of Java changes.
This commit introduces protocol buffer telemetric stream decoding.
|
/CC: @bernerdschaefer |
| } | ||
| switch mediatype { | ||
| case "application/vnd.google.protobuf": | ||
| // BUG(matt): Version? |
There was a problem hiding this comment.
Yeah, should the version conceptually be a subhierarchy of the media type? E.g. with protobuf version, we start at a separate 0.0.1 again, but use the same header to indicate it?
|
👍 in general, but we should reach some consensus about object creation styles. IMO unless there's a good reason for |
|
I don't have the exact details on hand, but a grep through the stdlib showed new(foo) to occur much more frequently than &foo{} (I believe 8 times more so). Bernerd On Jun 26, 2013, at 19:39, juliusv [email protected] wrote:
|
|
@bernerdschaefer I am betting, too, that you see this far more frequently for Staying idiomatic is important to me, even if there are consistency issues. As long as components are small, inconsistencies can be quickly remedied. |
…nation Support Protocol Buffer Message Decoding
The next API will support Protocol Buffer telemetry streams in addition to the standard JSON. This will enable more rapid development of additional clients while the simple text and JSON formats are added.