Refactor/reduce marshaling complexity #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| type counterVector struct { | ||
| labels map[string]string | ||
| value float64 | ||
| Labels map[string]string `json:"labels"` |
There was a problem hiding this comment.
I suppose these need to be publicized for encoding/json?
There was a problem hiding this comment.
Yes. Though, of course, they're only exposed within the package since the type is not exported.
|
👍 overall. Merge at your convenience. |
* Drop `AsMarshallable()` from the Metric interface. Use
`json.Marshaler` and `MarshalJSON()`, and leverage JSON struct tags
where possible.
* Add `MarshalJSON()` to Registry and remove `dumpToWriter`, which
makes the registry handler much simpler.
In addition to simplifying some of the marshalling behavior, this also
has the nice side effect of cutting down the number of
`map[string]interface{}` instances.
bernerdschaefer
added a commit
that referenced
this pull request
Apr 19, 2013
…plexity Refactor/reduce marshaling complexity
bernerdschaefer
merged commit 04c7f7b
into
refactor/user-experience/standardized-directories
|
Hey @bernerdschaefer, can you quickly validate that
are properly serialized for consumption? IIRC, that had been a motivation for self-encoding. There is—may be closed—bug against the Go JSON serialized for these. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsMarshallable()from the Metric interface. Usejson.MarshalerandMarshalJSON(), and leverage JSON struct tagswhere possible.
MarshalJSON()to Registry and removedumpToWriter, whichmakes the registry handler much simpler.
In addition to simplifying some of the marshalling behavior, this also
has the nice side effect of cutting down the number of
map[string]interface{}instances.