PROPOSAL: remove timer.go

[bernerdschaefer]

To me the following code is simpler, more idiomatic, and gives the same results as the timer API:

func foo() {
    defer func(began time.Time) {
        xyz.IncrementBy(map[string]string{}, time.Since(began))
    }(time.Now())

    // do some work
}

Also, as @matttproud notes the current timer code fails in the presence of a panic, while this does not.

For comparison, see the current registry handler vs. a version using the above pattern.

[matttproud]

Excellent. Will review shortly.
Am 19.04.2013 11:29 schrieb "Bernerd Schaefer" [email protected]:

To me the following code is simpler, more idiomatic, and gives the same
results as the timer API:

func foo() {
defer func(began time.Time) {
xyz.IncrementBy(map[string]string{}, time.Since(began))
}(time.Now())

// do some work}

Also, as @matttproud https://github.com/matttproud notes the current
timer code fails in the presence of a panic, while this does not.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11
.

[matttproud]

Sounds reasonable to me. I don't think anyone else is using it, since the API never matured—as you can see from just how rough it is.

For the future:
defer someCounter.IncrementWithDuration(labels, time.Now(), time.Second) defer someHistogram.AddWithDuration(labels, time.Now(), time.Second)

Often times labels may encapsulate the disposition of the operation.

[bernerdschaefer]

Great. I'll make a PR. Should I base off master, or the reorganization branch?

Bernerd

On Apr 19, 2013, at 13:13, "Matt T. Proud" [email protected] wrote:

Sounds reasonable to me. I don't think anyone else is using it, since the API never matured—as you can see from just how rough it is.

For the future:

defer someCounter.IncrementWithDuration(labels, time.Now(), time.Second)
defer someHistogram.AddWithDuration(labels, time.Now(), time.Second)

Often times labels may encapsulate the disposition of the operation.

—
Reply to this email directly or view it on GitHub.

[matttproud]

I would clone my reorganization branch.

2013/4/19 Bernerd Schaefer [email protected]

Great. I'll make a PR. Should I base off master, or the reorganization
branch?

Bernerd

On Apr 19, 2013, at 13:13, "Matt T. Proud" [email protected]
wrote:

Sounds reasonable to me. I don't think anyone else is using it, since
the API never matured—as you can see from just how rough it is.

For the future:

defer someCounter.IncrementWithDuration(labels, time.Now(), time.Second)
defer someHistogram.AddWithDuration(labels, time.Now(), time.Second)

Often times labels may encapsulate the disposition of the operation.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-16648699
.

[bernerdschaefer]

This is merged into the refactor branch. Closing.