add ConfigMap generate script #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also contains the generated ConfigMaps for the grafana dashboards as well as for alerts. These will be updated in subsequent changes as sets of alerts and dashboards are added/updated in the respective subdirectories in `/assets`.
|
Okay, we can remove etcd3 alerts for now. Theoretically, it shouldn't matter as the alerts will simply have no effect in absence of the used metrics. Rest sounds good. Documentation is the most important part of this repository, I'd say. So we should have it. 👍 |
|
sounds like a plan 👍 don't have merge rights ... if you would be so kind @fabxc 😁 |
|
You have now. |
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains the generated ConfigMaps for the grafana dashboards
as well as for alerts. These will be updated in subsequent changes as
sets of alerts and dashboards are added/updated in the respective
subdirectories in
/assets.In general this allows the dashboards to actually be reviewed as changes in the json are now actually visible. To be able to review them best it would be good if we always format them the same way. Right now I did this with
cat *-dashboard.json | python -m json.tool, which would be good to document at some point so people who want to contribute know the procedure. Let me know if you think we should do that straight away.@fabxc also let me know what you think about removing the etcd alerts for now. If you want I can add them back in, but then they will be included in the set of alerts in the ConfigMap, I figured that that might not be what we want right now.