This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Added metric for symbol table size #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <[email protected]>
gouthamve
approved these changes
Sep 11, 2018
| db.mtx.RUnlock() | ||
| symTblSize := float64(0) | ||
| for _, b := range blocks { | ||
| symTblSize += float64(b.GetSymbolTableSize()) |
There was a problem hiding this comment.
To avoid too many conversions, symTblSize := 0 and then return float64(symTblSize)
| @@ -138,6 +139,19 @@ func newDBMetrics(db *DB, r prometheus.Registerer) *dbMetrics { | |||
| defer db.mtx.RUnlock() | |||
| return float64(len(db.blocks)) | |||
| }) | |||
| m.symbolTableSize = prometheus.NewGaugeFunc(prometheus.GaugeOpts{ | |||
| Name: "prometheus_tsdb_symbol_table_size", | |||
There was a problem hiding this comment.
See: https://prometheus.io/docs/practices/naming/#metric-names
Should be prometheus_tsdb_symbol_table_size_bytes
|
Yes, it's a way to spot high cardinality issues. |
|
Note that this is |
|
I think the total's fine. |
|
Thanks for the input! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244, Supersedes #272
prometheus_tsdb_symbol_table_sizewill show the total size of symbol table of persisted blocks.Signed-off-by: Ganesh Vernekar [email protected]