Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Updates ConfigMap Name #63

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Updates ConfigMap Name #63

merged 1 commit into from
Oct 23, 2020

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 21, 2020 •
edited

Previously, the ConfigMap name was derived from contour.Name . This PR aligns the ConfigMap name with upstream until multiple Contour instances per namespace are supported.

/assign @jpeach @Miciah

Signed-off-by: Daneyon Hansen [email protected]

Miciah
Miciah reviewed Oct 21, 2020
View reviewed changes
Copy link

@Miciah Miciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how #18 necessitates this change. Is this change more about making the operator resources consistent with the quickstart resources?

controller/contour/configmap.go Show resolved Hide resolved
@danehans
Copy link
Contributor Author

I don't see how #18 necessitates this change. Is this change more about making the operator resources consistent with the quickstart resources?

@Miciah yes, I would like Contour child resources to following the upstream naming scheme until #18 is implemented.

@danehans
Updates ConfigMap Name
7f7fd90 
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans danehans requested a review from Miciah October 22, 2020 18:52
stevesloka
stevesloka approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Miciah
Copy link

Miciah commented Oct 22, 2020

/lgtm

@danehans danehans mentioned this pull request Oct 23, 2020
Merged
@jpeach jpeach merged commit c2305b3 into projectcontour:main Oct 23, 2020
@danehans danehans deleted the cfgmap_update branch November 2, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpeach jpeach jpeach approved these changes

@stevesloka stevesloka stevesloka approved these changes

@Miciah Miciah Awaiting requested review from Miciah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danehans @Miciah @jpeach @stevesloka