sync CRDs from projectcontour/contour

[skriss]

Signed-off-by: Steve Kriss [email protected]

[skriss]

Hmm, not sure why this is still showing a CRD error when running envtest-based tests, but not when running in kind clusters..

[skriss]

In light of #574, I opted to just disable the envtest-based tests rather than mucking around with kubebuilder versions/etc. since the tests are likely pretty redundant with E2E's anyway

[codecov]

Codecov Report

Base: 75.21% // Head: 49.63% // Decreases project coverage by -25.57% ⚠️

Coverage data is based on head (7189e7a) compared to base (e991cb9).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #573       +/-   ##
===========================================
- Coverage   75.21%   49.63%   -25.58%     
===========================================
  Files          29       29               
  Lines        2635     2635               
===========================================
- Hits         1982     1308      -674     
- Misses        512     1307      +795     
+ Partials      141       20      -121     

Impacted Files	Coverage Δ
internal/operator/config.go	0.00% <0.00%> (-100.00%)	⬇️
internal/controller/controller.go	0.00% <0.00%> (-72.67%)	⬇️
internal/operator/operator.go	0.00% <0.00%> (-72.50%)	⬇️
internal/objects/serviceaccount/service_account.go	0.00% <0.00%> (-71.16%)	⬇️
internal/objects/contour/finalizer.go	0.00% <0.00%> (-55.56%)	⬇️
internal/objects/rbac.go	0.00% <0.00%> (-51.82%)	⬇️
internal/status/status.go	0.00% <0.00%> (-50.00%)	⬇️
internal/objects/namespace/namespace.go	10.29% <0.00%> (-48.53%)	⬇️
pkg/slice/slice.go	50.00% <0.00%> (-45.84%)	⬇️
internal/objects/configmap/configmap.go	28.86% <0.00%> (-39.18%)	⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sunjayBhatia]

could the issue be a tools version? envtest etc. is probably pretty out of date here and on my dev machine currently

cool with dropping the tests since yeah we're planning on stopping supporting this anyways (and code hasn't changed tbh)

[skriss]

could the issue be a tools version? envtest etc. is probably pretty out of date here and on my dev machine currently

cool with dropping the tests since yeah we're planning on stopping supporting this anyways (and code hasn't changed tbh)

Yeah my best guess is it's due to an old envtest/associated binaries, but updating to kubebuilder v3 to get newer versions is not super-straightforward and I didn't see the point of going down that road. I think as long as we have the E2E's working we still have decent confidence here.