Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Adds initial Kubebuilder scaffolding #5

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

danehans
Copy link
Contributor

Scaffolds the project with Kubebuilder using projectcontour.io as the domain, operator as the group, Contour as the kind and v1alpha1 as the version.

/assign @jpeach @Miciah

Signed-off-by: Daneyon Hansen [email protected]

@@ -0,0 +1,27 @@
# Build the manager binary
FROM golang:1.13 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well begin with Go 1.15 :)

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; my only suggestion is that we might as well start off with Go 1.15.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah operator.projectcontour.io/Contour LGTM for the apigroup and name.

@danehans
Copy link
Contributor Author

/cc @sgreene570

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka stevesloka merged commit 7286473 into projectcontour:main Aug 31, 2020
@danehans danehans deleted the kubebuilder_scaffolding branch August 31, 2020 19:25
jpeach added a commit to jpeach/contour-operator that referenced this pull request Aug 31, 2020
Following on from projectcontour#5, when starting a new project, we should use the
latest Go release.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach mentioned this pull request Aug 31, 2020
jpeach added a commit to jpeach/contour-operator that referenced this pull request Aug 31, 2020
Following on from projectcontour#5, when starting a new project, we should use the
latest Go release.

Signed-off-by: James Peach <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants