This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
JobConfigChanged()
would always update the existing cert-genJob
due to API defaults not being set byDesiredJob()
.api/v1alpha1/contour_types.go
:OwningContourLabel
constant is moved fromcontroller/contour/controller.go
so it can be used by packages throughout the operator.controller/contour/job.go
: Adds fields that are defaulted by the api server.util/equality/equality.go
: Updates the equality comparison ofJobConfigChanged()
to only compare managedJob
fields. Reorders the returned values ofJobConfigChanged()
to be idiomatic.util/equality/equality_test.go
: Updates tests based onutil/equality/equality.go
changes./assign @jpeach @stevesloka
/cc @Miciah
Signed-off-by: Daneyon Hansen [email protected]