Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Adds Contour ConfigMap Support #30

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Sep 25, 2020

Adds support for managing Contour's ConfigMap.

Fixes #38

@jpeach @skriss @stevesloka @Miciah PTAL

@jpeach
Copy link
Contributor

jpeach commented Sep 29, 2020

I don't think the template is the right approach here. Contour should expose a package with the Go struct for the config file, and we can consume that directly here.

@jpeach
Copy link
Contributor

jpeach commented Sep 29, 2020

xref projectcontour/contour#2621

@stevesloka
Copy link
Member

The alternative would be to move the the CRD approach suggested here (projectcontour/contour#2924 (comment)), but is not built out just yet.

@danehans
Copy link
Contributor Author

danehans commented Oct 5, 2020

@jpeach is it possible to proceed with this approach since this is what's implemented today? I can create an issue that xrefs projectcontour/contour#2621 and projectcontour/contour#2924 (comment) and update the contour-operator when these projectcontour/contour issues are resolved.

@stevesloka
Copy link
Member

@danehans I think this is fine to move forward with. The CRD swap is a lot more work and will require a deprecation window that shouldn't hold up this project. =)

Signed-off-by: Daneyon Hansen <[email protected]>
@danehans
Copy link
Contributor Author

@stevesloka I've updated the PR based, PTAL.

/cc @jpeach @Miciah

@jpeach jpeach merged commit e7e656e into projectcontour:main Oct 13, 2020
@danehans danehans deleted the cntr_cfgmap branch November 2, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contour Configuration Support
3 participants