Add portmap plugin #338
Merged
Add portmap plugin #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not super stoked about having that binary checked in, since it will live in the history forever. But otherwise, the change looks fine. |
tomdee
approved these changes
Jun 5, 2017
|
Actually - please also say (somewhere) exactly what git hash the binary is built from. |
|
What's wrong with leaving it as a Dockerhub image (with binary in it) until the plugin PR is merged so we don't have to upload the binary to the repo? |
We could do that. It would mean that building that version of the calico/cni container wouldn't be easily reproducible (but we could include the commit hash from which it was built to make that easier?) |
5f548d1
to
afd172d
Compare
afd172d
to
66980c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the portmap plugin from containernetworking/plugins#1 to the cni installer. Currently, there is no release of the portmap plugin so this PR needs to wait until there is one.
Todos