-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerized dev #1474
base: main
Are you sure you want to change the base?
Dockerized dev #1474
Conversation
last of the typos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, and is working great for me. I just made two very minor suggestions to get the old README to jive with the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dl-maura nice work! This works locally for me.
I would advocate for cleaning up the multiple commits in this PR before a final review/merge. Also not sure where things are at with the testing -- let me know if you want a second pair of eyes.
Hi @dl-maura -- a fresh pull of this branch and I'm back to getting SQLite errors upon a |
Current state: this 'works' but some of the selenium tests are failing, I think because of ports needing to be exposed (the code that is failing is not affected at all by the work here). I am going to speak to a colleague who knows more than I do about Rails tests to see if I can get it worked out next week. |
This is building off of the Blacklight local docker development system, giving you an option to run a local dev using docker.
Fulfills ticket 1443.
To test, follow the readme directions and confirm it works! Recommend squash merging I had typos I had to fix so a lot of commit messages.