feat: add device type's icons to cards #1350
Conversation
src/components/ZclEndpointCard.vue
Outdated
| let category = '' | ||
| this.$store.state.zap.selectedZapConfig.zclProperties.forEach((item) => { | ||
| if (item.id === packageRef) { | ||
| category = item.category |
There was a problem hiding this comment.
return category once it has been populated.
| @@ -289,6 +300,15 @@ export default { | |||
| } | |||
| }, | |||
| methods: { | |||
| getDeviceCategory(packageRef) { | |||
There was a problem hiding this comment.
Keep the comment format as below for this function too
/** * Specifies the path to the logo image * * @param {*} isTiny - * if value "true", it's used as a tiny logo * if value "false", it's used as a normal logo * @param {*} category - * if value "zigbee", it's used as a zigbee logo * if value "matter", it's used as a matter logo * if value "multiprotocol", it's used as a multiprotocol logo * @param {*} isSelected - * if value "true", it's used as a dark / selected version * if value "false", it's used as a light version * @returns Returns a string value for the src image property */
tbrkollar
force-pushed
the
feature/add-device-type-to-card
branch
from
981b27f
to
0394873
Compare
| @@ -289,6 +300,15 @@ export default { | |||
| } | |||
| }, | |||
| methods: { | |||
| getDeviceCategory(packageRef) { | |||
There was a problem hiding this comment.
Keep the comment format as below for this function too
/** * Specifies the path to the logo image * * @param {*} isTiny - * if value "true", it's used as a tiny logo * if value "false", it's used as a normal logo * @param {*} category - * if value "zigbee", it's used as a zigbee logo * if value "matter", it's used as a matter logo * if value "multiprotocol", it's used as a multiprotocol logo * @param {*} isSelected - * if value "true", it's used as a dark / selected version * if value "false", it's used as a light version * @returns Returns a string value for the src image property */
src/components/ZclEndpointCard.vue
Outdated
| if (item.id === packageRef) { | ||
| if (item.category) { | ||
| category = item.category | ||
| return |
There was a problem hiding this comment.
Just realized the returning in a forEach does not really end the loop but it continues going through the loop regardless.
Can you switch this.$store.state.zap.selectedZapConfig.zclProperties.forEach((item) => { if (item.id === packageRef) { if (item.category) { category = item.category return } } })
to
let zclProperty = this.$store.state.zap.selectedZapConfig.zclProperties.find((item) => (item.id === packageRef && item.category)) if (zclProperty) { category = zclProperty.category } return category
There was a problem hiding this comment.
You can also switch to a normal for loop and return instead of using forEach
There was a problem hiding this comment.
you are right, thanks. i will fix it
No description provided.