Correct grammar, hyperlinks and formatting #17
Conversation
|
|
|
@ipadurean-bd thanks for the contribution, We don't use the acronym CSA we prefer "The Alliance" as a shortened term. |
|
@sammachin thank you! |
ipadurean-bd
force-pushed
the
ipadurean-corrections-bitdefender
branch
2 times, most recently
from
f201639
to
69427cf
Compare
|
@sammachin I see the |
|
@ipadurean-bd yeah I thought I'd fixed that yesterday, but your's is the first PR using it that's coming from an external repo so I can see its still failing. I'll take a look at that today, |
|
@ipadurean-bd |
ipadurean-bd
force-pushed
the
ipadurean-corrections-bitdefender
branch
from
69427cf
to
c547ebd
Compare
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
|
@sammachin done |
|
seems like the action was still checking out the main branch not your head, I've just updated it so could you fetch that change and we'll see what it builds this time |
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
|
@sammachin what is the situation on this pull request? It cannot be merged? |
|
@ipadurean-bd could you pull in the latest changes from main, that should trigger the preview to be re-deployed, there were some bugs in the github action used for the previews but it was also running the action in main and showing that as the preview without your changes! |
ipadurean-bd
force-pushed
the
ipadurean-corrections-bitdefender
branch
from
c547ebd
to
5b214c5
Compare
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
|
@sammachin so I should revert the images changes? |
Yes please, as you can now see in the preview the images don't load https://d1teub3jrrfss6.cloudfront.net/pr-17/howitworks/datamodel/ |
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
Correct acronym defined first for each document Use Alliance instead of CSA (two terms: Alliance and CSA were used for the Connectivity Standard Alliance) Correct grammar mistakes Correct formatting Apply uniform formatting of lists with dot at the end
ipadurean-bd
force-pushed
the
ipadurean-corrections-bitdefender
branch
from
4821db3
to
836e8fa
Compare
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
|
@sammachin I reverted the hyperlinks, but the preview still doesn't load the images |
ah I think that might be the cloudfront preview caching the previous pages, 2 mins I'll take a look |
|
yes it was the caching, I'll need to add an invalidation to the action in future, Thanks I'll review the rest of the edits today |
content/Alliance/_index.md
Outdated
| @@ -5,12 +5,10 @@ weight = 2 | |||
| pre = "<b>2. </b>" | |||
| +++ | |||
|
|
|||
|
|
|||
| # The Connectivity Standards Alliance | |||
| # The Connectivity Standards Alliance (The Alliance) | |||
There was a problem hiding this comment.
| # The Connectivity Standards Alliance (The Alliance) | |
| # The Connectivity Standards Alliance |
I agree that its useful to explain acroynms but this makes the H1 on the page far to long
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
|
thanks all looks good/ |
|
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-17 |
Correct acronym defined first for each document
Use Alliance instead of CSA (two terms: Alliance and CSA were used for the Connectivity Standard Alliance)
Correct grammar mistakes
Correct the hyperlinks
Correct formatting
Apply uniform formatting of lists with dot at the end