-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use-after-move check of clang-tidy #8414
Conversation
@mspang I'm not quite familiar with GN, please help me check if I'm using it correctly, any suggestions are welcome. |
Hm, interesting approach. A couple things make me nervous about this such as needing to duplicate the command line generation. Could use pw_command_launcher to avoid that. It's probably OK to let the build actually happen and then run the analyzer after. The other way is to just use compile_commands.json which is what I believe everyone else does (this way also requires building first). |
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not hooked up to any automation yet, right?
Usage: gn --root=. gen --check --fail-on-unused-args ./out/debug "--args=target_os=\"all\" is_clang=true pw_command_launcher=\"`pwd`/scripts/helpers/clang-tidy-launcher.py\"" ninja -v -C out/debug More checks can be added by modifying .clang-tidy
Size increase report for "esp32-example-build" from f382df3
Full report output
|
Not yet, there is lots of failure with it enabled, we can make it non mandatory check first. Waiting for @andy31415 coming back to add a new CI check. |
Usage: gn --root=. gen --check --fail-on-unused-args ./out/debug "--args=target_os=\"all\" is_clang=true pw_command_launcher=\"`pwd`/scripts/helpers/clang-tidy-launcher.py\"" ninja -v -C out/debug More checks can be added by modifying .clang-tidy
Problem
#2814
#7044
Change overview
Add build rule to run
clang-tidy
Testing
Manually tested.