Add use-after-move check of clang-tidy

[kghost]

Problem

#2814
#7044

Change overview

Add build rule to run clang-tidy

Testing

Manually tested.

  gn --root=. gen --check --fail-on-unused-args ./out/debug "--args=target_os=\"all\" is_clang=true pw_command_launcher=\"`pwd`/scripts/helpers/clang-tidy-launcher.py\""
  ninja -v -C out/debug

[kghost]

@mspang I'm not quite familiar with GN, please help me check if I'm using it correctly, any suggestions are welcome.

[mspang]

@mspang I'm not quite familiar with GN, please help me check if I'm using it correctly, any suggestions are welcome.

Hm, interesting approach. A couple things make me nervous about this such as needing to duplicate the command line generation.

Could use pw_command_launcher to avoid that. It's probably OK to let the build actually happen and then run the analyzer after.

The other way is to just use compile_commands.json which is what I believe everyone else does (this way also requires building first).

[bzbarsky-apple]

/rebase

[bzbarsky-apple]

Not hooked up to any automation yet, right?

[github-actions]

Size increase report for "esp32-example-build" from f382df3

File	Section	File	VM
chip-temperature-measurement-app.elf	.flash.text	47	60

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,4049
.flash.text,60,47

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

[kghost]

Not hooked up to any automation yet, right?

Not yet, there is lots of failure with it enabled, we can make it non mandatory check first.

Waiting for @andy31415 coming back to add a new CI check.