-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using weak functions for Aliro command callbacks. #33931
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:aliro-better-callbacks
Jun 14, 2024
Merged
Stop using weak functions for Aliro command callbacks. #33931
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:aliro-better-callbacks
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a delegate; we should just make use of the delegate. This is not a breaking change because nothing implements Aliro bits yet. Also: * Fixes some incorrect early returns that did not respond to commands. * Fixes some validity checks that were not quite correct per spec. * Fixes some logging levels for errors. * Adds missing "mark these attributes dirty" bits. * Marks various functions that don't touch our members as static.
PR #33931: Size comparison from a12a0c0 to 283a364 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
approved these changes
Jun 14, 2024
yufengwangca
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a delegate; we should just make use of the delegate. This is not a breaking change because nothing implements Aliro bits yet.
Also: