Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to CommandSender and CommandHandler for supporting commands with large payloads #33889

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Changes to CommandSender and CommandHandler for supporting commands with large payloads #33889

merged 1 commit into from
Jun 14, 2024

Conversation

pidarped
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited

PR #33889: Size comparison from 1a8c6d2 to 8da04a9

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1a8c6d2 8da04a9 change % change
bl602 lighting-app bl602 FLASH 1267948 1268428 480 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282226 1282706 480 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1306906 1307386 480 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088588 1089068 480 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099538 1100018 480 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178668 1179148 480 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872188 872668 480 0.1
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123784 1124320 536 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075730 1076210 480 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086992 1087472 480 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797636 797924 288 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813440 813736 296 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802804 803092 288 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755292 755596 304 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740940 741236 296 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604902 605150 248 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650690 650938 248 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661149 661465 316 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681001 681309 308 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681001 681309 308 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637937 638245 308 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603325 603641 316 0.1
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622969 623277 308 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622969 623277 308 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619117 619433 316 0.1
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638841 639149 308 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638841 639149 308 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587365 587669 304 0.1
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607209 607521 312 0.1
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607209 607521 312 0.1
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887760 888064 304 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701568 701904 336 0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968628 968972 344 0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466124 1466424 300 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535363 1535671 308 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2531824 2532336 512 0.0
RAM 129072 129104 32 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568382 5569118 736 0.0
RAM 483000 483032 32 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052168 5052872 704 0.0
RAM 236792 236824 32 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477496 4477976 480 0.0
RAM 216752 216768 16 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11511063 11513639 2576 0.0
RAM 535202 535226 24 0.0
chip-tool-ipv6only arm64 unknown 19792 19792 0 0.0
FLASH 10649252 10651204 1952 0.0
RAM 583200 583224 24 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11281207 1128378 2576 0.0
RAM 528786 528818 32 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347112 4347592 480 0.0
RAM 208800 208816 16 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5365538 5366018 480 0.0
RAM 225392 225424 32 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4542840 4543336 496 0.0
RAM 204208 204224 16 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177320 4177848 528 0.0
RAM 193200 193216 16 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4301784 4302536 752 0.0
RAM 197840 197872 32 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799949 2800541 592 0.0
RAM 154392 154416 24 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149604 4150180 576 0.0
RAM 234584 234608 24 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5587128 5587928 800 0.0
RAM 345640 345672 32 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9559046 9561574 2528 0.0
RAM 352800 352816 16 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497404 1497724 320 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873856 874152 296 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948556 948764 208 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821832 822132 300 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575260 575460 200 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590384 590592 208 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609224 609440 216 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673552 673856 304 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610052 1610316 264 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534260 1534524 264 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460548 1460780 232 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1463076 232 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650128 650424 296 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610116 610412 296 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472028 472252 224 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625172 625318 146 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600770 600990 220 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770382 770602 220 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668302 668448 146 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626924 627070 146 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712762 712990 228 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557908 558132 224 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792970 793194 224 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660228 660374 146 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686638 686862 224 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609124 609306 182 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599472 599654 182 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633318 633464 146 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642310 642534 224 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618374 618556 182 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464694 464840 146 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1612836 1613384 548 0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15735450 15740962 5512 0.0
RAM 6902388 6903232 844 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jun 13, 2024
View reviewed changes
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerExchangeInterface.h Outdated Show resolved Hide resolved
src/app/CommandHandlerImpl.cpp Outdated Show resolved Hide resolved
src/app/CommandResponseSender.cpp Outdated Show resolved Hide resolved
src/app/CommandResponseSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
@pidarped pidarped force-pushed the LargeCommandSupportNew branch 2 times, most recently from 86b2420 to ec1f3c1 Compare June 14, 2024 00:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited

PR #33889: Size comparison from 60ae46d to ec1f3c1

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 60ae46d ec1f3c1 change % change
bl602 lighting-app bl602 FLASH 1268236 1268626 390 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1282514 1282904 390 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1307194 1307584 390 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1088876 1089266 390 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099826 1100216 390 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178956 1179346 390 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872476 872866 390 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124174 1124612 438 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076018 1076408 390 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087280 1087670 390 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797864 798136 272 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813668 813940 272 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803056 803328 272 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755552 755816 264 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741184 741448 264 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605378 605602 224 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651166 651390 224 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661413 661689 276 0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681265 681541 276 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681265 681541 276 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638201 638477 276 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603589 603865 276 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623233 623509 276 0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623233 623509 276 0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619373 619649 276 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639097 639373 276 0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639097 639373 276 0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587629 587901 272 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607473 607753 280 0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607473 607753 280 0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 888024 888296 272 0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699912 700232 320 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969084 969428 344 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1469096 1469366 270 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538019 1538287 268 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2533808 2534288 480 0.0
RAM 129072 129104 32 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5583182 5583870 688 0.0
RAM 483208 483240 32 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5054184 5054856 672 0.0
RAM 236792 236824 32 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4479496 4479960 464 0.0
RAM 216752 216768 16 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11520535 11523063 2528 0.0
RAM 535394 535418 24 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10658068 10659908 1840 0.0
RAM 583416 583440 24 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11290695 11293223 2528 0.0
RAM 528978 529010 32 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4349096 4349576 480 0.0
RAM 208800 208816 16 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5367554 5368002 448 0.0
RAM 225392 225424 32 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4544872 4545304 432 0.0
RAM 204208 204224 16 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4179352 4179816 464 0.0
RAM 193200 193216 16 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4303768 4304488 720 0.0
RAM 197840 197872 32 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2802765 2803325 560 0.0
RAM 154392 154416 24 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4151860 4152324 464 0.0
RAM 234584 234608 24 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5589304 5590056 752 0.0
RAM 345640 345672 32 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9568102 9570598 2496 0.0
RAM 352800 352816 16 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497660 1497868 208 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876604 876872 268 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950224 950404 180 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822156 822424 268 0.0
RAM 138027 138027 0 0.0
nxp contact k32w0+release FLASH 575436 575620 184 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590552 590728 176 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609384 609568 184 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 673744 674008 264 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613772 1614004 232 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534716 1534964 248 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1460988 1461204 216 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463300 1463516 216 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650352 650624 272 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610404 610668 264 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472260 472444 184 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625418 625534 116 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602942 603132 190 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770624 770814 190 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668544 668660 116 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627170 627286 116 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713008 713206 198 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558150 558344 194 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793212 793406 194 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660474 660590 116 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 686880 687074 194 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609370 609522 152 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599718 599870 152 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633552 633668 116 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642556 642750 194 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618620 618772 152 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464934 465050 116 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1622328 1622824 496 0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15753330 15758530 5200 0.0
RAM 6912572 6913260 688 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 14, 2024
View reviewed changes
src/app/CommandHandlerImpl.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited

PR #33889: Size comparison from a12a0c0 to fda5375

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a12a0c0 fda5375 change % change
bl602 lighting-app bl602 FLASH 1269916 1270292 376 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284194 1284570 376 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309130 1309506 376 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1090556 1091188 632 0.1
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1101506 1101882 376 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1180636 1181012 376 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874156 874532 376 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1126382 1126798 416 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1077698 1078074 376 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1088960 1089336 376 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797600 797856 256 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813260 813516 256 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802792 803048 256 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755592 755840 248 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741248 741496 248 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605586 605794 208 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651214 651422 208 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661173 661433 260 0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681017 681277 260 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681017 681277 260 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637953 638213 260 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603637 603897 260 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623273 623533 260 0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623273 623533 260 0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619141 619401 260 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638857 639117 260 0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638857 639117 260 0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587717 587965 248 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607569 607825 256 0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607569 607825 256 0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 887768 888000 232 0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699880 700184 304 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969212 969492 280 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468444 1468696 252 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1537607 1537867 260 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2533920 2534352 432 0.0
RAM 129072 129104 32 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5579230 5579886 656 0.0
RAM 483240 483272 32 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052920 5053544 624 0.0
RAM 236792 236824 32 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4479528 4479944 416 0.0
RAM 216752 216768 16 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11521847 11524327 2480 0.0
RAM 535426 535450 24 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10659316 10661124 1808 0.0
RAM 583448 583472 24 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11292023 11294503 2480 0.0
RAM 529010 529042 32 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4349352 4349784 432 0.0
RAM 208800 208816 16 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366722 5367122 400 0.0
RAM 225392 225424 32 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543736 4544136 400 0.0
RAM 204208 204224 16 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4179640 4180072 432 0.0
RAM 193200 193216 16 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4303880 4304536 656 0.0
RAM 197840 197872 32 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2800733 2801245 512 0.0
RAM 154392 154416 24 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152436 4152884 448 0.0
RAM 234584 234608 24 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5593928 5594632 704 0.0
RAM 345640 345672 32 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9568294 9570726 2432 0.0
RAM 352800 352816 16 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497436 1497580 144 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 875740 875992 252 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948860 949024 164 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821952 822208 256 0.0
RAM 138027 138027 0 0.0
nxp contact k32w0+release FLASH 575228 575380 152 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590360 590520 160 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609288 609472 184 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 673760 674008 248 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613260 1613476 216 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534588 1534804 216 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1460940 1461124 184 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463268 1463468 200 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650120 650376 256 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610252 610500 248 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 471948 472116 168 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625438 625536 98 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602186 602358 172 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770328 770500 172 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668524 668622 98 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627160 627258 98 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712966 713146 180 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557850 558026 176 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792926 793102 176 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660300 660398 98 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 686846 687022 176 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609344 609478 134 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599730 599864 134 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633522 633620 98 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642584 642760 176 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618620 618754 134 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464848 464946 98 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1620576 1621040 464 0.0
RAM 45412 45412 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15755698 15760842 5144 0.0
RAM 6913544 6914216 672 0.0

@mergify mergify bot merged commit ec8547a into project-chip:master Jun 14, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pidarped @yufengwangca @bzbarsky-apple