Cherry-pick: TC-RR-1.1: Fix for pre-existing fabric removal (#32921) #33596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TC-RR-1.1: Fix for pre-existing fabric removal
This test assumed that the client ordering matched to the ordering
of the fabric table, but this is not the case if there is a fabric
on the device before the test starts. In this case, the initial
fabric is in table slot 1 with index 1, the test starts in table
slot 2, with fabric index 2. Then the initial fabric is removed
from table slot 1, and the test adds a new fabric. The new fabric
is allocated fabric index 3, but appears in slot 1 in the table,
and the order between the controllers and the fabric table as read
off the device is now out of sync.
Instead, name the controllers based on the fabric index rather
than the index in the fabric table.
TEST: commissioned all-clusters using chip-tool then ran RR-1.1.
Test now passes, whereas before there was a failure.
* Update src/python_testing/TC_RR_1_1.py
Co-authored-by: Andrei Litvin <[email protected]>
* Update src/python_testing/TC_RR_1_1.py
* Address review comments, fix
---------
Co-authored-by: Andrei Litvin <[email protected]>
andy31415
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test assumed that the client ordering matched to the ordering of the fabric table, but this is not the case if there is a fabric on the device before the test starts. In this case, the initial fabric is in table slot 1 with index 1, the test starts in table slot 2, with fabric index 2. Then the initial fabric is removed from table slot 1, and the test adds a new fabric. The new fabric is allocated fabric index 3, but appears in slot 1 in the table, and the order between the controllers and the fabric table as read off the device is now out of sync.
Instead, name the controllers based on the fabric index rather than the index in the fabric table.
TEST: commissioned all-clusters using chip-tool then ran RR-1.1.
Test now passes, whereas before there was a failure.
Update src/python_testing/TC_RR_1_1.py
Update src/python_testing/TC_RR_1_1.py
Address review comments, fix