Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinMDNS skip interfaces without IPv4 addresses #32356

Merged
merged 1 commit into from
Feb 29, 2024
Merged

MinMDNS skip interfaces without IPv4 addresses #32356

merged 1 commit into from
Feb 29, 2024

Conversation

agners
Copy link
Contributor

@agners agners commented Feb 28, 2024

IPv4 multicast require an IPv4 address to be present on a particular interface. Skip interfaces without IPv4 addresses in the default address policy. This avoids errors when trying to join the multicast group later on:

MDNS failed to join multicast group on veth3cdf62f for address type IPv4: src/inet/UDPEndPointImplSockets.cpp:777: Inet Error 0x00000110: Address not found

@github-actions github-actions bot added the lib label Feb 28, 2024
@agners
MinMDNS skip interfaces without IPv4 addresses
e9428af 
IPv4 multicast require an IPv4 address to be present on a particular
interface. Skip interfaces without IPv4 addresses in the default
address policy. This avoids errors when trying to join the multicast
group later on:
MDNS failed to join multicast group on veth3cdf62f for address type IPv4: src/inet/UDPEndPointImplSockets.cpp:777: Inet Error 0x00000110: Address not found
@marcelveldt marcelveldt mentioned this pull request Feb 28, 2024
Closed
@agners agners force-pushed the skip-interfaces-without-ipv4-for-mdns branch from 5977bf2 to e9428af Compare February 28, 2024 09:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

PR #32356: Size comparison from 6f621f2 to e9428af

Decreases (3 builds for efr32)
platform target config section 6f621f2 e9428af change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 931336 931328 -8 -0.0
.text 732012 732004 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1121892 1121884 -8 -0.0
.text 932316 932308 -8 -0.0
window-app BRD4187C (read/write) 1155480 1155472 -8 -0.0
.text 984748 984740 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 6f621f2 e9428af change % change
bl602 lighting-app bl602 (read/write) 1435890 1435890 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 158324 158324 0 0.0
.text 1102094 1102094 0 0.0
bl602+mfd (read/write) 1450554 1450554 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 157284 157284 0 0.0
.text 1117668 1117668 0 0.0
bl602+rpc (read/write) 1483546 1483546 0 0.0
.bss 93360 93360 0 0.0
.data 9880 9880 0 0.0
.rodata 165900 165900 0 0.0
.text 1133740 1133740 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1200703 1200703 0 0.0
.bss 11117 11117 0 0.0
.data 3680 3680 0 0.0
.rodata 107680 107680 0 0.0
.text 971358 971358 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1211755 1211755 0 0.0
.bss 11293 11293 0 0.0
.data 3656 3656 0 0.0
.rodata 106620 106620 0 0.0
.text 983368 983368 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1292431 1292431 0 0.0
.bss 19581 19581 0 0.0
.data 4224 4224 0 0.0
.rodata 123052 123052 0 0.0
.text 1046310 1046310 0 0.0
bl706-eth (read/write) 1018277 1018277 0 0.0
.bss 23692 23692 0 0.0
.data 3256 3256 0 0.0
.rodata 101012 101012 0 0.0
.text 762348 762348 0 0.0
bl706-wifi (read/write) 1252686 1252686 0 0.0
.bss 10561 10561 0 0.0
.data 3696 3696 0 0.0
.rodata 122012 122012 0 0.0
.text 994012 994012 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1170048 1170048 0 0.0
.bss 16312 16312 0 0.0
.data 5040 5040 0 0.0
.rodata 101684 101684 0 0.0
.text 964228 964228 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1181456 1181456 0 0.0
.bss 16488 16488 0 0.0
.data 5024 5024 0 0.0
.rodata 100624 100624 0 0.0
.text 976550 976550 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773084 773084 0 0.0
(read/write) 168600 168600 0 0.0
.bss 90604 90604 0 0.0
.data 3560 3560 0 0.0
.rodata 81700 81700 0 0.0
.text 691120 691120 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 789620 789620 0 0.0
(read/write) 178848 178848 0 0.0
.bss 100852 100852 0 0.0
.data 3560 3560 0 0.0
.rodata 75948 75948 0 0.0
.text 713408 713408 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 778260 778260 0 0.0
(read/write) 173288 173288 0 0.0
.bss 95292 95292 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 675296 675296 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 730436 730436 0 0.0
(read/write) 167568 167568 0 0.0
.bss 89336 89336 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 652800 652800 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 716060 716060 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89560 89560 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 642584 642584 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582026 582026 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86530 86530 0 0.0
.text 493372 493372 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627386 627386 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106994 106994 0 0.0
.text 518268 518268 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 568307 568307 0 0.0
.app_xip_area 458085 458085 0 0.0
.bss 65056 65056 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551019 551019 0 0.0
.app_xip_area 436037 436037 0 0.0
.bss 69808 69808 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571019 571019 0 0.0
.app_xip_area 462301 462301 0 0.0
.bss 63592 63592 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564091 564091 0 0.0
.app_xip_area 452093 452093 0 0.0
.bss 66792 66792 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 931336 931328 -8 -0.0
.bss 197912 197912 0 0.0
.data 1388 1388 0 0.0
.text 732012 732004 -8 -0.0
BRD4187C (read/write) 1108920 1108920 0 0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 910340 910340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121892 1121884 -8 -0.0
.bss 186764 186764 0 0.0
.data 2792 2792 0 0.0
.text 932316 932308 -8 -0.0
window-app BRD4187C (read/write) 1155480 1155472 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 984748 984740 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1210560 1210560 0 0.0
(read/write) 1749472 1749472 0 0.0
.dram0.bss 74296 74296 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252016 252016 0 0.0
.flash.text 1210560 1210560 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1252835 1252835 0 0.0
(read/write) 536028 536028 0 0.0
.dram0.bss 81208 81208 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 283736 283736 0 0.0
.flash.text 1246671 1246671 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605296 605296 0 0.0
(read/write) 79608 79608 0 0.0
.bss 67428 67428 0 0.0
.data 2196 2196 0 0.0
.text 604760 604760 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 746700 746700 0 0.0
.bss 79188 79188 0 0.0
.data 2816 2816 0 0.0
.text 625328 625328 0 0.0
light k32w0+release (read only) 609192 609192 0 0.0
(read/write) 79492 79492 0 0.0
.bss 67308 67308 0 0.0
.data 2200 2200 0 0.0
.text 608656 608656 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 789560 789560 0 0.0
.bss 80580 80580 0 0.0
.data 2032 2032 0 0.0
.text 667592 667592 0 0.0
lock k32w0+release (read only) 588864 588864 0 0.0
(read/write) 77480 77480 0 0.0
.bss 65348 65348 0 0.0
.data 2148 2148 0 0.0
.text 588328 588328 0 0.0
linux air-purifier-app debug (read only) 2611381 2611381 0 0.0
(read/write) 128832 128832 0 0.0
.bss 46448 46448 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74216 74216 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 184240 184240 0 0.0
.text 2249797 2249797 0 0.0
all-clusters-app debug (read only) 5917641 5917641 0 0.0
(read/write) 480304 480304 0 0.0
.bss 134784 134784 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 333608 333608 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349264 349264 0 0.0
.text 5135123 5135123 0 0.0
all-clusters-minimal-app debug (read only) 5198193 5198193 0 0.0
(read/write) 236224 236224 0 0.0
.bss 127584 127584 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 97176 97176 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288290 288290 0 0.0
.text 4675315 4675315 0 0.0
bridge-app debug (read only) 4592833 4592833 0 0.0
(read/write) 217104 217104 0 0.0
.bss 118112 118112 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86112 86112 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228930 228930 0 0.0
.text 4143731 4143731 0 0.0
chip-tool debug (read only) 12028809 12028809 0 0.0
(read/write) 521448 521448 0 0.0
.bss 94392 94392 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414712 414712 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448313 448313 0 0.0
.text 10874819 10874819 0 0.0
chip-tool-ipv6only arm64 (read only) 11353068 11353068 0 0.0
(read/write) 588752 588752 0 0.0
.bss 103464 103464 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454496 454496 0 0.0
.dynamic 512 512 0 0.0
.got 16984 16984 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 354364 354364 0 0.0
.text 10120488 10120488 0 0.0
lighting-app debug+rpc+ui (read only) 5516209 5516209 0 0.0
(read/write) 225896 225896 0 0.0
.bss 119048 119048 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94512 94512 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 353972 353972 0 0.0
.text 4915683 4915683 0 0.0
lock-app debug (read only) 4660577 4660577 0 0.0
(read/write) 204720 204720 0 0.0
.bss 113536 113536 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80360 80360 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 254946 254946 0 0.0
.text 4194099 4194099 0 0.0
ota-provider-app debug (read only) 4292409 4292409 0 0.0
(read/write) 193192 193192 0 0.0
.bss 113216 113216 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69744 69744 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207490 207490 0 0.0
.text 3892067 3892067 0 0.0
ota-requestor-app debug (read only) 4421689 4421689 0 0.0
(read/write) 197592 197592 0 0.0
.bss 114112 114112 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72864 72864 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213634 213634 0 0.0
.text 4010659 4010659 0 0.0
shell debug (read only) 2885625 2885625 0 0.0
(read/write) 156256 156256 0 0.0
.bss 62672 62672 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86432 86432 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185152 185152 0 0.0
.text 2527250 2527250 0 0.0
thermostat-no-ble arm64 (read only) 4412356 4412356 0 0.0
(read/write) 242336 242336 0 0.0
.bss 121768 121768 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103576 103576 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159116 159116 0 0.0
.text 3918744 3918744 0 0.0
tv-app debug (read only) 5683665 5683665 0 0.0
(read/write) 351464 351464 0 0.0
.bss 243376 243376 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94328 94328 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 288034 288034 0 0.0
.text 5153811 5153811 0 0.0
tv-casting-app debug (read only) 9859329 9859329 0 0.0
(read/write) 340096 340096 0 0.0
.bss 156112 156112 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174168 174168 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 382640 382640 0 0.0
.text 9011091 9011091 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531528 2531528 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1494212 1494212 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1102292 1102292 0 0.0
bss 130831 130831 0 0.0
rodata 112812 112812 0 0.0
text 810796 810796 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1221564 1221564 0 0.0
bss 122921 122921 0 0.0
rodata 141772 141772 0 0.0
text 806344 806344 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1050552 1050552 0 0.0
bss 129689 129689 0 0.0
rodata 100184 100184 0 0.0
text 772848 772848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834464 834464 0 0.0
(read/write) 1795228 1795228 0 0.0
.bss 196212 196212 0 0.0
.data 2664 2664 0 0.0
.text 1587964 1587964 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1717340 1717340 0 0.0
.bss 193092 193092 0 0.0
.data 2632 2632 0 0.0
.text 1513228 1513228 0 0.0
light cy8ckit_062s2_43012 (read only) 844344 844344 0 0.0
(read/write) 1636460 1636460 0 0.0
.bss 186556 186556 0 0.0
.data 2440 2440 0 0.0
.text 1439076 1439076 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1666356 1666356 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1441812 1441812 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129096 1129096 0 0.0
.bss 102456 102456 0 0.0
.data 820 820 0 0.0
.text 641480 641480 0 0.0
lock-app qpg6105+debug (read/write) 1089192 1089192 0 0.0
.bss 97200 97200 0 0.0
.data 840 840 0 0.0
.text 601572 601572 0 0.0
stm32 light STM32WB5MM-DK (read/write) 600301 600301 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 79596 79596 0 0.0
.text 381992 381992 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823254 823254 0 0.0
bss 49660 49660 0 0.0
text 616136 616136 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1091944 1091944 0 0.0
bss 101780 101780 0 0.0
text 793154 793154 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1049440 1049440 0 0.0
bss 110084 110084 0 0.0
text 764502 764502 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 910168 910168 0 0.0
bss 93116 93116 0 0.0
text 651992 651992 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824934 824934 0 0.0
bss 49708 49708 0 0.0
text 617874 617874 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 930596 930596 0 0.0
bss 77708 77708 0 0.0
text 697970 697970 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1073324 1073324 0 0.0
bss 100196 100196 0 0.0
text 777356 777356 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 903012 903012 0 0.0
bss 69172 69172 0 0.0
text 653254 653254 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 929064 929064 0 0.0
bss 92696 92696 0 0.0
text 670924 670924 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 827494 827494 0 0.0
bss 49816 49816 0 0.0
text 620830 620830 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 791200 791200 0 0.0
bss 56016 56016 0 0.0
text 591580 591580 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677152 677152 0 0.0
bss 73672 73672 0 0.0
text 462410 462410 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832470 832470 0 0.0
bss 51340 51340 0 0.0
text 624244 624244 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 850921 850921 0 0.0
bss 59492 59492 0 0.0
text 636048 636048 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 816868 816868 0 0.0
bss 56304 56304 0 0.0
text 611288 611288 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 834972 834972 0 0.0
bss 68080 68080 0 0.0
text 626544 626544 0 0.0

@mergify mergify bot merged commit 2011f76 into project-chip:master Feb 29, 2024
58 checks passed
Sarthak-Shaha pushed a commit to Sarthak-Shaha/connectedhomeip_silabs that referenced this pull request Mar 5, 2024
@agners @Sarthak-Shaha
MinMDNS skip interfaces without IPv4 addresses (project-chip#32356)
fb0555d 
IPv4 multicast require an IPv4 address to be present on a particular
interface. Skip interfaces without IPv4 addresses in the default
address policy. This avoids errors when trying to join the multicast
group later on:
MDNS failed to join multicast group on veth3cdf62f for address type IPv4: src/inet/UDPEndPointImplSockets.cpp:777: Inet Error 0x00000110: Address not found
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@agners @huangxuyong
MinMDNS skip interfaces without IPv4 addresses (project-chip#32356)
c3f9e8e 
IPv4 multicast require an IPv4 address to be present on a particular
interface. Skip interfaces without IPv4 addresses in the default
address policy. This avoids errors when trying to join the multicast
group later on:
MDNS failed to join multicast group on veth3cdf62f for address type IPv4: src/inet/UDPEndPointImplSockets.cpp:777: Inet Error 0x00000110: Address not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agners @tcarmelveilleux @andy31415 @woody-apple